Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo on @aws-cdk/aws-cloudwatch: MetricAarmProps -> MetricAlarmProps #1760

Closed
yumemi-nohshiro opened this issue Feb 14, 2019 · 0 comments · Fixed by #1765
Closed

Typo on @aws-cdk/aws-cloudwatch: MetricAarmProps -> MetricAlarmProps #1760

yumemi-nohshiro opened this issue Feb 14, 2019 · 0 comments · Fixed by #1765
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort

Comments

@yumemi-nohshiro
Copy link

I found a typo in @aws-cdk/aws-cloudwatch package.

https://github.com/awslabs/aws-cdk/blob/67fcf6dffccb2dcbbcc649997d421d39fef6ebf7/packages/%40aws-cdk/aws-cloudwatch/lib/metric.ts#L299

- export interface MetricAarmProps {
+ export interface MetricAlarmProps {
@sam-goodwin sam-goodwin added the bug This issue is a bug. label Feb 14, 2019
rix0rrr pushed a commit that referenced this issue Feb 14, 2019
fix(cloudwatch): fix name of 'MetricAlarmProps'
43215bf 
Fixes #1760.

BREAKING CHANGE: Rename 'MetricAarmProps' => 'MetricAlarmProps'.
@rix0rrr rix0rrr mentioned this issue Feb 14, 2019
Merged
4 tasks
rix0rrr added a commit that referenced this issue Feb 14, 2019
@rix0rrr
fix(cloudwatch): fix name of 'MetricAlarmProps' (#1765)
c87f09a 
Fixes #1760.

BREAKING CHANGE: Rename 'MetricAarmProps' => 'MetricAlarmProps'.
@fulghum fulghum added the effort/small Small work item – less than a day of effort label Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cloudwatch): fix name of 'MetricAlarmProps' aws/aws-cdk
3 participants
@fulghum @sam-goodwin @yumemi-nohshiro