Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codedeploy.LambdaDeploymentGroup role is not "IRole" #1833

Closed
cybergoof opened this issue Feb 21, 2019 · 0 comments · Fixed by #1840
Closed

codedeploy.LambdaDeploymentGroup role is not "IRole" #1833

cybergoof opened this issue Feb 21, 2019 · 0 comments · Fixed by #1840
Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy bug This issue is a bug. effort/small Small work item – less than a day of effort

Comments

@cybergoof
Copy link

In the construction of the LambdaDeploymentGroup, the "role" property is of type "Role" rather than IRole.

https://github.com/awslabs/aws-cdk/blob/488935ce9e2a414c94fbf13fc24c95c9626f7d11/packages/%40aws-cdk/aws-codedeploy/lib/lambda/deployment-group.ts#L79
@rix0rrr rix0rrr added bug This issue is a bug. effort/small Small work item – less than a day of effort @aws-cdk/aws-codedeploy Related to AWS CodeDeploy labels Feb 22, 2019
rix0rrr added a commit that referenced this issue Feb 22, 2019
@rix0rrr
fix(codedeploy): LambdaDeploymentGroup now takes IRole
59bc347 
Change the arguments of LambdaDeploymentGroup to take interfaces
wherever possible.

Fixes #1833.
@rix0rrr rix0rrr mentioned this issue Feb 22, 2019
Merged
4 tasks
rix0rrr added a commit that referenced this issue Feb 27, 2019
@rix0rrr
fix(codedeploy): LambdaDeploymentGroup now takes IRole (#1840)
f6adb7c 
Change the arguments of LambdaDeploymentGroup to take interfaces
wherever possible.

Fixes #1833.

BREAKING CHANGE: If an existing role is provided to a LambdaDeploymentGroup, 
you will need to provide the assuming service principal (`codedeploy.amazonaws.com`) 
yourself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy bug This issue is a bug. effort/small Small work item – less than a day of effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(codedeploy): LambdaDeploymentGroup now takes IRole aws/aws-cdk
2 participants
@rix0rrr @cybergoof