feat(elbv2): add fixed response support for application load balancers #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It follows the same pattern as the one used for `addTargetGroups` with the check on `priority`. This allows for the following scenario: an infrastructure stack exporting an application listener with a default fixed response and multiple application stacks registering their services with specific paths/headers on the imported application listener.
rix0rrr
reviewed
May 6, 2019
| /** | ||
| * The fixed response | ||
| */ | ||
| readonly fixedResponse: FixedResponse |
There was a problem hiding this comment.
These properties should be inlined. You can do that by going extends AddRuleProps, FixedResponse and silencing the linter error.
rix0rrr
approved these changes
May 6, 2019
|
lol |
SanderKnape
pushed a commit
to SanderKnape/aws-cdk
that referenced
this pull request
May 14, 2019
aws#2328) It follows the same pattern as the one used for `addTargetGroups` with the check on `priority`. This allows for the following scenario: an infrastructure stack exporting an application listener with a default fixed response and multiple application stacks registering their services with specific paths/headers on the imported application listener.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It follows the same pattern as the one used for
addTargetGroupswith the check onpriority.This allows for the following scenario: an infrastructure stack exporting an application listener with
a default fixed response and multiple application stacks registering their services with specific
paths/headers on the imported application listener.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.