Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-ecs): allow linux parameters to be settable #2397

Merged
merged 3 commits into from
May 7, 2019

Conversation

SoManyHs
Copy link
Contributor

@SoManyHs SoManyHs commented Apr 30, 2019

Fixes #2380


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@SoManyHs SoManyHs requested a review from rix0rrr April 30, 2019 00:56
@SoManyHs SoManyHs requested a review from a team as a code owner April 30, 2019 00:56
@SoManyHs
Copy link
Contributor Author

Note: Running npm run build spits out a lot of warnings about breaking API changes, though they seemed to be for unrelated resources?

@SoManyHs SoManyHs changed the title fix(aws-ecs): allow linux paramters to be settable fix(aws-ecs): allow linux parameters to be settable Apr 30, 2019
sharedMemorySize: 1024,
});

linuxParameters.addCapabilities(ecs.Capability.All);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test where we do linuxParameters.addCapabilities() after passing them to addContainer()? Since the object is mutable, I'd like to confirm that order doesn't matter, and that this stays true even if we refactor in the future.

@rix0rrr rix0rrr merged commit 417e5e8 into aws:master May 7, 2019
@rix0rrr rix0rrr deleted the linux-params branch May 7, 2019 08:21
SanderKnape pushed a commit to SanderKnape/aws-cdk that referenced this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECS task definition does not allow you to set linuxParameters, it is read only
2 participants