-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-ecs): allow linux parameters to be settable #2397
Conversation
Note: Running |
sharedMemorySize: 1024, | ||
}); | ||
|
||
linuxParameters.addCapabilities(ecs.Capability.All); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test where we do linuxParameters.addCapabilities()
after passing them to addContainer()
? Since the object is mutable, I'd like to confirm that order doesn't matter, and that this stays true even if we refactor in the future.
Fixes #2380
Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.