-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecr: grant methods cause circular references in generated templates #2473
Closed
otterley opened this issue
May 3, 2019
· 1 comment
· Fixed by #3220 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed
ecr: grant methods cause circular references in generated templates #2473
otterley opened this issue
May 3, 2019
· 1 comment
· Fixed by #3220 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
Comments
otterley
changed the title
ecr: grant methods cause circular references in generate template
ecr: grant methods cause circular references in generated templates
May 3, 2019
A workaround for the moment is to use the |
rix0rrr
added a commit
that referenced
this issue
Jul 5, 2019
When granting to a cross-account principal the repository would use a self-reference to obtain the right ARN to use in its own resource policy, which can obviously never work. The solution is to use a '*' resource ARN. Fixes #2473.
eladb
pushed a commit
that referenced
this issue
Jul 7, 2019
When granting to a cross-account principal the repository would use a self-reference to obtain the right ARN to use in its own resource policy, which can obviously never work. The solution is to use a '*' resource ARN. Fixes #2473.
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
grant*
methods on the ecr.Repository class incorrectly add self-references to the repository's policies, leading to a circular reference error.Example code:
Rendered template (in relevant part):
ECR repository policies do not require resources to be defined (or they can be set to
*
) -- see the documentation for examples.The text was updated successfully, but these errors were encountered: