-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using . in artifactId, use - instead, per the usual conventions. #490
Conversation
I still think we should drop the |
Discussed off-line with @kiiadi and came to the following conclusion:
|
1f07d50
to
8f452df
Compare
Updated PR to change |
@@ -77,14 +77,35 @@ process.stdout.write(` | |||
|
|||
<dependencies> | |||
<dependency> | |||
<groupId>com.amazonaws</groupId> | |||
<groupId>software.amazon.jsii</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of interest - how are we releasing jsii? I noticed from the repo there that it's org.jsii - did we want to keep that? or is this an amazon-branded product?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll be published under software.amazon.jsii
, and supposedly all places were updated accordingly (somehow this one seems to have slept though).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.