Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update the s2n submodule to include changes from aws/s2n-tls#4878 #612

Open
1 of 2 tasks
nforro opened this issue Dec 5, 2024 · 5 comments
Open
1 of 2 tasks

Please update the s2n submodule to include changes from aws/s2n-tls#4878 #612

nforro opened this issue Dec 5, 2024 · 5 comments
Labels
dependencies This issue is a problem in a dependency. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@nforro
Copy link
Contributor

nforro commented Dec 5, 2024

Describe the feature

Would it be possible to update the s2n submodule to include changes from aws/s2n-tls#4878?

Use Case

With the changes it will be possible to build aws-crt-python in the latest Fedora and RHEL10 without deprecated openssl-devel-engine.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@nforro nforro added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 5, 2024
@graebm
Copy link
Contributor

graebm commented Dec 5, 2024

Whenever we update the C submodules, we pull in their latest releases. That PR was just merged to main a few hours ago. S2N usually makes a new release every week or so. I'll keep an eye out for the next release

@jmklix jmklix added dependencies This issue is a problem in a dependency. p2 This is a standard priority issue labels Dec 5, 2024
@nforro
Copy link
Contributor Author

nforro commented Dec 5, 2024

Thank you!

@jmklix jmklix added pending-release This issue will be fixed by an approved PR that hasn't been released yet. and removed needs-triage This issue or PR still needs to be triaged. feature-request A feature should be added or improved. labels Dec 11, 2024
@yselkowitz
Copy link

https://github.com/aws/s2n-tls/releases/tag/v1.5.10 includes the requested change

@waahm7 waahm7 mentioned this issue Dec 18, 2024
Merged
@waahm7
Copy link
Contributor

waahm7 commented Dec 18, 2024

Thanks, this is fixed in https://github.com/awslabs/aws-crt-python/releases/tag/v0.23.6. It should be available on PiWheels in a few hours if nothing goes wrong with the release.

@yselkowitz
Copy link

Thanks, the Fedora package has been successfully updated without the engine dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies This issue is a problem in a dependency. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jmklix @waahm7 @yselkowitz @nforro @graebm