Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Swift support for flexible checksums #198

Closed
2 tasks
smivij opened this issue Sep 21, 2023 · 2 comments
Closed
2 tasks

Add Swift support for flexible checksums #198

smivij opened this issue Sep 21, 2023 · 2 comments
Assignees
@waahm7
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Milestone
GA

Comments

@smivij
Copy link

smivij commented Sep 21, 2023

Describe the feature

As per Flexible Checksums SEP, we need to support below checksum algorithms and need support from CRT for it.

CRC32C
CRC32
SHA256
SHA1

I believe all of these are already implemented in CRT, we need Swift bindings for these. I believe SHA256 already has Swift bindings, need work for the others.

Use Case

please refer to flexible checksum SEP

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@smivij smivij added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 21, 2023
@smivij smivij added this to the GA milestone Sep 21, 2023
@yasminetalby yasminetalby added p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Sep 27, 2023
@waahm7 waahm7 mentioned this issue Nov 6, 2023
Merged
@waahm7
Copy link
Contributor

waahm7 commented Nov 7, 2023

Released in 0.18.0.

@waahm7 waahm7 closed this as completed Nov 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waahm7 waahm7

Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Milestone
GA
Development

No branches or pull requests
3 participants
@waahm7 @yasminetalby @smivij