Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple CI & submodule Update #245

Merged
merged 14 commits into from
Apr 1, 2024
Merged

Apple CI & submodule Update #245

merged 14 commits into from
Apr 1, 2024

Conversation

xiazhvera
Copy link
Contributor

@xiazhvera xiazhvera commented Apr 1, 2024

Issue #, if available:

Description of changes:
#238 <= The PR was first created and approved here. This PR is used to bring the CI changes into main.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@xiazhvera
Copy link
Contributor Author

#238 <= The PR was first created and approved here. This PR is used to bring the CI changes into main.

@xiazhvera xiazhvera changed the title Apple CI Update Apple CI & submodule Update Apr 1, 2024
Copy link
Contributor

@waahm7 waahm7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if want to bring aws-c-mqtt library & target before anything else relating to MQTT. Also, this PR adds the module but never calls aws_mqtt_library_init which seems wrong.

Package.swift Outdated Show resolved Hide resolved
@xiazhvera xiazhvera merged commit 5c90a98 into main Apr 1, 2024
25 checks passed
@xiazhvera xiazhvera deleted the apple_ci branch April 1, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants