Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Write and run tests against examples as part of the CI process #425

Closed
flochaz opened this issue Jan 6, 2022 · 4 comments
Closed

Maintenance: Write and run tests against examples as part of the CI process #425

flochaz opened this issue Jan 6, 2022 · 4 comments
Assignees
@flochaz
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Milestone
production-ready-...

Comments

@flochaz
Copy link
Contributor

flochaz commented Jan 6, 2022 •
edited
Loading

Description of the feature request

Problem statement
Examples are for now only ran manually through manual CDK deploy and manual deployed resource check.

Summary of the feature

  1. Add E2E tests (following what is done in each packages e2e tests to automate cdk stack deployment).
  2. Add a step in CI to run them as part of merge to main.

Related issues, RFCs

Avoid issue like #423 and #424

Blocked by: aws/aws-cdk#18211
@flochaz flochaz added the triage This item has not been triaged by a maintainer, please wait label Jan 6, 2022
@dreamorosi dreamorosi added this to the production-ready-release milestone Jan 6, 2022
@dreamorosi dreamorosi added all automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) and removed triage This item has not been triaged by a maintainer, please wait labels Jan 6, 2022
This was referenced Jan 6, 2022
Closed
Merged
@dreamorosi
Copy link
Contributor

If we do this we'll need to downgrade the examples to cdk version 1.x right?

@flochaz
Copy link
Contributor Author

flochaz commented Jan 25, 2022

yep probably :( that is the reason why I didn't tackled this yet ...

@flochaz flochaz added the blocked This item's progress is blocked by external dependency or reason label Jan 25, 2022
@flochaz
Copy link
Contributor Author

flochaz commented Mar 18, 2022

Current workflow is giving enough confidence by relying on typescript build to test example don't get broken by new release pkg.

@flochaz flochaz closed this as completed Mar 18, 2022
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed blocked This item's progress is blocked by external dependency or reason labels Nov 14, 2022
@dreamorosi dreamorosi changed the title chore(examples): Write and run tests against examples as part of the CI process Maintenance: Write and run tests against examples as part of the CI process Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flochaz flochaz

Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Milestone
production-ready-release
Development

No branches or pull requests
3 participants
@flochaz @dreamorosi @saragerion