Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Swift 5.5 & 5.6 support #1010

Closed
2 tasks
jbelkins opened this issue May 18, 2023 · 7 comments
Closed
2 tasks

Drop Swift 5.5 & 5.6 support #1010

jbelkins opened this issue May 18, 2023 · 7 comments
Assignees
@jbelkins
Labels
feature-request A feature should be added or improved.
Milestone
GA

Comments

@jbelkins
Copy link
Contributor

Describe the feature

Remove support for Swift 5.5 & 5.6 on aws-sdk-swift and smithy-swift, leaving Swift 5.7 as the minimum supported Swift version. For reference, Swift 5.7 was introduced in Xcode 14.0 in September 2022.

Specific tasks:

  • Set swift-tools-version and other minimum Swift version limits in our targets from 5.5 to 5.7.
  • Remove conditional code for Swift version 5.5 & 5.6.
  • Remove Swift 5.5 & 5.6 from CI tasks, replace with versions up to latest Swift where needed.
  • Remove Catapult builds using Swift 5.5 & 5.6

Use Case

  • To allow for the use of more modern Swift
  • To reduce the burden of supporting old Swift versions
  • To reduce the complexity and build time on build & CI systems

Proposed Solution

Specific tasks:

  • Set swift-tools-version and other minimum Swift version limits in our targets from 5.5 to 5.7.
  • Remove conditional code for Swift version 5.5 & 5.6.
  • Remove Swift 5.5 & 5.6 from CI tasks, replace with versions up to latest Swift where needed.
  • Remove Catapult builds using Swift 5.5 & 5.6, replace with versions up to latest Swift where needed.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@jbelkins jbelkins added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 18, 2023
@jbelkins
Copy link
Contributor Author

This task is blocked by amplify-swift currently supporting Swift 5.6.

This task may be unblocked once amplify-swift raises their minimum Swift version to 5.7.

@jbelkins jbelkins added blocked Work is blocked on this issue for this codebase. Other labels or comments may indicate why. amplify Related to aws-amplify/amplify-swift labels May 18, 2023
@jbelkins
Copy link
Contributor Author

Be sure to inform AWS doc writers prior to the release of this change in requirements.

@jbelkins jbelkins added this to the GA milestone May 22, 2023
@jbelkins jbelkins removed the needs-triage This issue or PR still needs to be triaged. label May 22, 2023
@jbelkins jbelkins self-assigned this Sep 26, 2023
@jbelkins jbelkins removed the blocked Work is blocked on this issue for this codebase. Other labels or comments may indicate why. label Sep 26, 2023
@jbelkins
Copy link
Contributor Author

Amplify dropped Swift 5.6 support in amplify-swift 2.18.0 so we are now free to move to Swift 5.7 as our minimum for SDK and smithy-swift.

Removing the "Blocked" label accordingly.

@jbelkins
Copy link
Contributor Author

The CI part of this ticket will be accomplished in #1132 and #1133.

@jbelkins
Copy link
Contributor Author

@shepazon Tagged you here for your info

@jbelkins
Copy link
Contributor Author

jbelkins commented Oct 2, 2023

Build system has been updated to run Xcode 14.0 / Swift 5.7 minimum, Xcode 15.0 / Swift 5.9 max.
Internal ref: CR-102886049

@jbelkins jbelkins removed the amplify Related to aws-amplify/amplify-swift label Oct 2, 2023
This was referenced Oct 6, 2023
Merged
Merged
@dayaffe
Copy link
Contributor

dayaffe commented Oct 17, 2023

Released in 0.28

@dayaffe dayaffe closed this as completed Oct 17, 2023
@waahm7 waahm7 mentioned this issue Oct 19, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbelkins jbelkins

Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
GA
Development

No branches or pull requests
2 participants
@jbelkins @dayaffe