Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Integration succeeds when build actually failed #1046

Closed
jbelkins opened this issue Jun 21, 2023 · 1 comment
Closed

Model Integration succeeds when build actually failed #1046

jbelkins opened this issue Jun 21, 2023 · 1 comment
Assignees
Labels
bug This issue is a bug.

Comments

@jbelkins
Copy link
Contributor

Describe the bug

The Model Integration CI task succeeds when its Swift build & test stage fails.

Example run: https://github.com/awslabs/aws-sdk-swift/actions/runs/5331072196/jobs/9658455576

It appears that after a failure, the test runner Swift CLI script does not fail with the appropriate error code.

Expected Behavior

Model build fails on error
Model Integration CI task fails on error as well

Current Behavior

Model build fails on error
Model Integration CI succeeds

Reproduction Steps

Push code that contains a Swift build error
Run "Model Integration" CI task manually on that commit

Possible Solution

Make the AWSSDKSwiftCLI test runner fail with the appropriate exit code

Additional Information/Context

No response

AWS SWIFT SDK version used

main / latest

Compiler and Version used

Xcode 14.3.1

Operating System and version

macOS 13.3

@jbelkins jbelkins added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 21, 2023
@jbelkins jbelkins self-assigned this Jun 21, 2023
@jbelkins
Copy link
Contributor Author

jbelkins commented Jul 3, 2023

Shipped in AWS SDK for Swift 0.20.0

@jbelkins jbelkins closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

1 participant