Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Address edge case in Shape.isInHttpBody() function #1213

Closed
Tracked by #710
dayaffe opened this issue Oct 31, 2023 · 1 comment
Closed
Tracked by #710

fix: Address edge case in Shape.isInHttpBody() function #1213

dayaffe opened this issue Oct 31, 2023 · 1 comment
Labels
bug This issue is a bug.

Comments

@dayaffe
Copy link
Contributor

dayaffe commented Oct 31, 2023

Describe the bug

The following comment was left in the code:
// TODO fix the edge case: a shape which is an operational input (i.e. has members bound to HTTP semantics) could be re-used elsewhere not as an operation input which means everything is in the body

Related issue: #710

Expected Behavior

fun Shape.isInHttpBody() checks to see if a shape is in the body of the http request. This should work for any valid shape with bound members.

Current Behavior

The TODO comment suggests that the code logic does not work properly when an input to operation is re-used elsewhere not as an input to an operation.

Reproduction Steps

This issue includes the work to re-produce this edge case which can likely be accomplished by creating a smithy file and corresponding test.

Possible Solution

No response

Additional Information/Context

No response

AWS SWIFT SDK version used

to be confirmed

Compiler and Version used

to be confirmed

Operating System and version

to be confirmed

@dayaffe dayaffe added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 31, 2023
@dayaffe dayaffe changed the title Address edge case in Shape.isInHttpBody() function bug: Address edge case in Shape.isInHttpBody() function Oct 31, 2023
@dayaffe dayaffe changed the title bug: Address edge case in Shape.isInHttpBody() function fix: Address edge case in Shape.isInHttpBody() function Oct 31, 2023
@sichanyoo sichanyoo removed the needs-triage This issue or PR still needs to be triaged. label Nov 6, 2023
@sichanyoo
Copy link
Contributor

Moved to 2143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants