Bug: Protocol tests added in Smithy 1.46.0 do not pass

[dayaffe]

Describe the bug

S3 URI resolution behavior when dealing with object keys that contain dot segments is incorrect (smithy-lang/smithy#2166)

Expected Behavior

All S3 protocol tests should pass

Current Behavior

Tests do not pass

Reproduction Steps

Test Case '-[S3TestSDKTests.GetObjectRequestTest testS3PreservesEmbeddedDotSegmentInUriLabel]' started.
/Users/dayaffe/Documents/Development/SwiftSDKWorkspace/UpdateSmithy/aws-sdk-swift/codegen/protocol-test-codegen/build/smithyprojections/protocol-test-codegen/s3/swift-codegen/S3TestSDKTests/GetObjectRequestTest.swift:99: error: -[S3TestSDKTests.GetObjectRequestTest testS3PreservesEmbeddedDotSegmentInUriLabel] : failed - actual query items in Endpoint is nil but expected are not
/Users/dayaffe/Documents/Development/SwiftSDKWorkspace/UpdateSmithy/aws-sdk-swift/codegen/protocol-test-codegen/build/smithyprojections/protocol-test-codegen/s3/swift-codegen/S3TestSDKTests/GetObjectRequestTest.swift:99: error: -[S3TestSDKTests.GetObjectRequestTest testS3PreservesEmbeddedDotSegmentInUriLabel] : XCTAssertEqual failed: ("foo/../key.txt") is not equal to ("/mybucket/foo/../key.txt")
/Users/dayaffe/Documents/Development/SwiftSDKWorkspace/UpdateSmithy/aws-sdk-swift/codegen/protocol-test-codegen/build/smithyprojections/protocol-test-codegen/s3/swift-codegen/S3TestSDKTests/GetObjectRequestTest.swift:99: error: -[S3TestSDKTests.GetObjectRequestTest testS3PreservesEmbeddedDotSegmentInUriLabel] : XCTAssertEqual failed: ("mybucket.s3.us-west-2.amazonaws.com") is not equal to ("s3.us-west-2.amazonaws.com")
Test Case '-[S3TestSDKTests.GetObjectRequestTest testS3PreservesEmbeddedDotSegmentInUriLabel]' failed (0.294 seconds).
Test Case '-[S3TestSDKTests.GetObjectRequestTest testS3PreservesLeadingDotSegmentInUriLabel]' started.
/Users/dayaffe/Documents/Development/SwiftSDKWorkspace/UpdateSmithy/aws-sdk-swift/codegen/protocol-test-codegen/build/smithyprojections/protocol-test-codegen/s3/swift-codegen/S3TestSDKTests/GetObjectRequestTest.swift:50: error: -[S3TestSDKTests.GetObjectRequestTest testS3PreservesLeadingDotSegmentInUriLabel] : failed - actual query items in Endpoint is nil but expected are not
/Users/dayaffe/Documents/Development/SwiftSDKWorkspace/UpdateSmithy/aws-sdk-swift/codegen/protocol-test-codegen/build/smithyprojections/protocol-test-codegen/s3/swift-codegen/S3TestSDKTests/GetObjectRequestTest.swift:50: error: -[S3TestSDKTests.GetObjectRequestTest testS3PreservesLeadingDotSegmentInUriLabel] : XCTAssertEqual failed: ("/../key.txt") is not equal to ("/mybucket/../key.txt")
/Users/dayaffe/Documents/Development/SwiftSDKWorkspace/UpdateSmithy/aws-sdk-swift/codegen/protocol-test-codegen/build/smithyprojections/protocol-test-codegen/s3/swift-codegen/S3TestSDKTests/GetObjectRequestTest.swift:50: error: -[S3TestSDKTests.GetObjectRequestTest testS3PreservesLeadingDotSegmentInUriLabel] : XCTAssertEqual failed: ("mybucket.s3.us-west-2.amazonaws.com") is not equal to ("s3.us-west-2.amazonaws.com")
Test Case '-[S3TestSDKTests.GetObjectRequestTest testS3PreservesLeadingDotSegmentInUriLabel]' failed (0.002 seconds).
Test Suite 'GetObjectRequestTest' failed at 2024-04-02 17:11:24.558.
	 Executed 2 tests, with 6 failures (0 unexpected) in 0.296 (0.296) seconds

Possible Solution

No response

Additional Information/Context

No response

AWS SWIFT SDK version used

latest

Compiler and Version used

latest

Operating System and version

mac

[dayaffe]

We have decided to disable the 2 tests in question in order to proceed with the upgrade. The tests are failing because we have a placeholder for endpoint resolution used only for protocol tests, not because of an actual failure. Go v2 and typescript SDKs also do not currently run these tests.

[sichanyoo]

The 2 tests disabled here were moved to different location and are now run correctly. Refer to #1590 to details.