Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route 53 TrimHostedZone customization is incomplete #1446

Closed
jbelkins opened this issue Apr 21, 2024 · 1 comment
Closed

Route 53 TrimHostedZone customization is incomplete #1446

jbelkins opened this issue Apr 21, 2024 · 1 comment
Assignees
Labels
bug This issue is a bug.

Comments

@jbelkins
Copy link
Contributor

Describe the bug

Currently, the Swift SDK applies the TrimHostedZone customization to 14 Route 53 operations that require it.

However, there are additional operations that need the customization but do not receive it.

They are:

  • deleteHostedZone
  • deleteReusableDelegationSet
  • getHostedZone
  • getReusableDelegationSet
  • getReusableDelegationSetLimit
  • updateHostedZoneComment

These operations are currently omitted because the input member holding the hosted zone ID that is bound to the URL is not specifically named hostedZoneId.

Expected Behavior

All Route 53 operations should function correctly.

Current Behavior

The Route 53 operations listed above fail on hosted zone ID validation errors when called with a validation ID.

Reproduction Steps

  • Create a hosted zone via API & store the hosted zone ID.
  • Call operation listed above with the ID of the zone created.

Possible Solution

No response

Additional Information/Context

No response

AWS SWIFT SDK version used

main

Compiler and Version used

Xcode 15.3

Operating System and version

macOS 14

@jbelkins jbelkins added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 21, 2024
@jbelkins jbelkins self-assigned this Apr 21, 2024
@jbelkins jbelkins removed the needs-triage This issue or PR still needs to be triaged. label Apr 22, 2024
@dayaffe
Copy link
Contributor

dayaffe commented May 7, 2024

Released in 0.43

@dayaffe dayaffe closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants