Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultEndpointResolver throws compile warnings #807

Closed
jbelkins opened this issue Jan 5, 2023 · 0 comments · Fixed by #809
Closed

DefaultEndpointResolver throws compile warnings #807

jbelkins opened this issue Jan 5, 2023 · 0 comments · Fixed by #809
Assignees
Labels
bug This issue is a bug.

Comments

@jbelkins
Copy link
Contributor

jbelkins commented Jan 5, 2023

Describe the bug

Every AWS service's default endpoint resolver throws this warning three times when compiled:

No calls to throwing functions occur within 'try' expression

This is apparently due to the CRT functions being called no longer throwing.

To fix, remove try from method calls to methods that cannot throw.

Expected Behavior

Compile main branch of SDK. Default endpoint resolvers should compile without warnings.

Current Behavior

Compile main branch of SDK. Default endpoint resolvers compile with the warning

No calls to throwing functions occur within 'try' expression

thrown three times.

Reproduction Steps

N/A

Possible Solution

Remove try from method calls to methods that cannot throw.

Additional Information/Context

No response

AWS SWIFT SDK version used

Latest / main

Compiler and Version used

Xcode 14.2

Operating System and version

macOS 12.6.2

@jbelkins jbelkins added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 5, 2023
@jbelkins jbelkins changed the title (short issue description) DefaultEndpointResolver throws compile warnings Jan 5, 2023
@jbelkins jbelkins self-assigned this Jan 5, 2023
@ganeshnj ganeshnj removed the needs-triage This issue or PR still needs to be triaged. label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants