Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should use makeError() to create a RestXMLError (#1360) #1361

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

dayaffe
Copy link
Contributor

@dayaffe dayaffe commented Feb 21, 2024

Released in https://github.com/awslabs/aws-sdk-swift/releases/tag/0.36.1

Issue #

Addresses an issue where RestXMLErrors do not get returned properly if the error httpResponse.statusCode == NotFound

Description of changes

  • use makeError function instead of directly creating a RestXMLErrror

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@sichanyoo sichanyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dayaffe dayaffe temporarily deployed to Integration-Test February 22, 2024 19:22 — with GitHub Actions Inactive
@dayaffe dayaffe temporarily deployed to Integration-Test February 22, 2024 19:22 — with GitHub Actions Inactive
@dayaffe dayaffe temporarily deployed to Integration-Test February 22, 2024 19:22 — with GitHub Actions Inactive
@dayaffe dayaffe temporarily deployed to Integration-Test February 22, 2024 19:22 — with GitHub Actions Inactive
@dayaffe dayaffe merged commit 44834c4 into main Feb 22, 2024
17 checks passed
@dayaffe dayaffe deleted the release/0.36.1 branch February 22, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants