chore: Rename filenames of integ tests & Improve EventBridge SigV4A integ tests #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revent concurrent modifications to same event buses during Github CI.
sichanyoo
temporarily deployed
to
Codegen-Build-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Codegen-Build-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
changed the title
sichanyoo
changed the title
jbelkins
reviewed
Mar 4, 2024
| @@ -11,7 +11,7 @@ import AWSS3 | |||
| import AWSClientRuntime | |||
|
|
|||
| // Please provide your-access-key and your-secret-key in Resources/credenitals | |||
| class ProcessCredentialProviderTests: XCTestCase { | |||
| class ProcessAWSCredentialIdentityResolverTests: XCTestCase { | |||
There was a problem hiding this comment.
Should the file be renamed to match the test class?
There was a problem hiding this comment.
Fixed to match the name.
sichanyoo
temporarily deployed
to
Codegen-Build-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
approved these changes
Mar 4, 2024
sichanyoo
deleted the
fix/make-eventbridge-integ-test-use-unique-bus-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
EventBridge SigV4 integration test improvement:
This is required to allow Github CI to run the tests in multiple platforms in parallel. Otherwise, spurious failures may occur due to concurrent modifications to the same eventbuses.
Rename integration tests that used to use "credentials provider" naming convention to now use "aws credential identity resolver" naming convention.
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.