Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is KinesisFirehoseToS3Props.existingBucketObj of type s3.Bucket and not s3.IBucket #33

Closed
cfredhart opened this issue Jul 31, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@cfredhart
Copy link

cfredhart commented Jul 31, 2020

I am trying to create a KinesisFirehose to an existing S3 bucket. I would like to be able to pass the existing bucket (not created via CDK or CloudFormation) to the KinesisFirehoseToS3 constructor in the KinesisFirehoseToS3Props. I am looking the bucket up using Bucket.fromBucketName which returns an IBucket rather than a Bucket. Since the existingBucketObj attribute of KinesisFirehoseToS3Props is of type Bucket, I cannot pass the IBucket reference to this construct.

It appears that the implementation of KinesisFirehoseToS3 does not make use of any features of the existingBucketObj property that are not in IBucket. Would it be possible to change the type of the existingBucketObj property to Ibucket?

@hnishar hnishar added the bug Something isn't working label Jul 31, 2020
@hnishar
Copy link
Contributor

hnishar commented Jul 31, 2020

cfredhart@ thanks for reporting the issue, we will look into it and provide the fix for it soon. Please keep the feedback coming.

@hnishar
Copy link
Contributor

hnishar commented Aug 7, 2020

cfredhart@ the update has been pushed out in the latest release v1.57.0, for proof see the integegration test case here and the resulting CFN template here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants