Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

feat: make smartHandler more configurable #24

Merged
merged 4 commits into from
Feb 11, 2021
Merged

feat: make smartHandler more configurable #24

merged 4 commits into from
Feb 11, 2021

Conversation

rsmayda
Copy link
Contributor

@rsmayda rsmayda commented Feb 10, 2021

Description of changes:

  • Added more documentation
  • updated THIRD_PARTY file
  • Moved the is 'Practitioner' (Admin) check to the handler and not the helper
  • Making adminAccessTypes & bulkDataAccessTypes configurable

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rsmayda rsmayda added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 10, 2021
@rsmayda rsmayda self-assigned this Feb 10, 2021
carvantes
carvantes previously approved these changes Feb 10, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
nguyen102
nguyen102 previously approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@nguyen102 nguyen102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, very thorough documentation. One minor text change suggestion.

One question: Will we be linking users to a reference Auth Server implementation anywhere? Specifically the Okta Auth server?

README.md Outdated Show resolved Hide resolved
nguyen102
nguyen102 reviewed Feb 11, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
nguyen102
nguyen102 reviewed Feb 11, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@rsmayda rsmayda merged commit 503ef8a into mainline Feb 11, 2021
@rsmayda rsmayda deleted the clean-code branch February 11, 2021 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nguyen102 nguyen102 nguyen102 approved these changes

@carvantes carvantes Awaiting requested review from carvantes

Assignees

@rsmayda rsmayda

Labels
documentation Improvements or additions to documentation enhancement New feature or request size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsmayda @carvantes @nguyen102