This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyen102
reviewed
Nov 24, 2020
nguyen102
reviewed
Nov 24, 2020
const { hostname, resourceType, id } = match.groups!; | ||
return { hostname, resourceType, id }; | ||
} | ||
throw new UnauthorizedError("Requester's identity is in the incorrect format"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to pass along the userIdentity
in the error message for context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am hesitant as it may contain PII -- I think better to log/return less
nguyen102
previously approved these changes
Nov 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some minor comments.
nguyen102
approved these changes
Nov 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
verifyAccessToken
changesfhirUser
regex is now a constantFHIR_USER_REGEX
fhirUser
is expected to be an absolute urlfhirUser
claim is not in the right format we rejectauthorizeAndFilterReadResponse
changesfhirUser
claimisWriteRequestAuthorized
changesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.