This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
feat: use fhirServiceBaseUrl from requests if present #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsmayda
reviewed
Jul 15, 2021
rsmayda
approved these changes
Jul 15, 2021
carvantes
added a commit
that referenced
this pull request
Aug 17, 2021
* feat: use fhirServiceBaseUrl from requests if present (#45) * chore: update fhir-works-on-aws-interface version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Use the
fhirServiceBaseUrlfrom the incoming auth request instead of the staticthis.apiUrlset in the constructor.This package uses the
apiUrlto perform checks in launch_response/fhirUser claims and when building references to be used in search filters. In a multi-tenant setup theapiUrlcan be different for each tenant. This change allows the client (i.e. the router package) to specify the api url to be used in the AuthZ check for a given request.fhirServiceBaseUrltakes precedence overthis.apiUrlas it is more specific(specific to the incoming request). This is a non-breaking change for single tenant setups.See:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.