Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

fix: scope checking for getting status on an export #64

Merged
merged 2 commits into from
Sep 10, 2021
Merged

fix: scope checking for getting status on an export #64

merged 2 commits into from
Sep 10, 2021

Conversation

rsmayda
Copy link
Contributor

@rsmayda rsmayda commented Sep 9, 2021 •
edited
Loading

Description of changes:

  • Change scope checking on non - initiate-export operations
    • It will now allow if system or user scope
    • This does not change the requirement that the job owner MUST match the requestor id
  • removed ['*', 'read'].includes(smartScope.accessType) check as it was duplicative

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rsmayda rsmayda self-assigned this Sep 9, 2021
@github-actions github-actions bot added the size/m label Sep 9, 2021
Bingjiling
Bingjiling reviewed Sep 10, 2021
View reviewed changes
src/smartScopeHelper.ts Show resolved Hide resolved
src/smartScopeHelper.ts Show resolved Hide resolved
@Bingjiling Bingjiling self-requested a review September 10, 2021 17:32
Bingjiling
Bingjiling approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@Bingjiling Bingjiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsmayda rsmayda merged commit 69f9297 into mainline Sep 10, 2021
@rsmayda rsmayda deleted the get-export-status branch September 10, 2021 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bingjiling Bingjiling Bingjiling approved these changes

@carvantes carvantes Awaiting requested review from carvantes

@ssvegaraju ssvegaraju Awaiting requested review from ssvegaraju

Assignees

@rsmayda rsmayda

Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsmayda @Bingjiling