This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
feat: add getCapabilities method to Search interface #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2021
nguyen102
reviewed
Jan 7, 2021
src/search.ts
Outdated
| export interface SearchCapabilities { | ||
| searchParam: { | ||
| name: string; | ||
| definition: string; |
There was a problem hiding this comment.
Based on this, the cardinality is 0..1
Looks like definition and documentation can be optional?
There was a problem hiding this comment.
true. I changed both to be optional. Our implementation will always include those fields though, but this makes the interface more flexible for others.
nguyen102
approved these changes
Jan 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The output of
getCapabilitieswill be used to build the CapabilityStatement for/metadataBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.