This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
feat: Add ResourceConflictError #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carvantes
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
Looks good.
Just make sure to update the PR name(and the resulting merge commit msg) before merging.
Commit message should be about the changes in this package, not about the overall feature that we are working on. Also, be careful about the distinction between fix: and feat: as they end up bumping the version in different ways. https://www.conventionalcommits.org/en/v1.0.0/
A better commit msg would be:
feat: Add ResourceConflictError
|
Also, you need to merge and release this PR and then update the interface version on awslabs/fhir-works-on-aws-routing#109 to have unit tests pass there. This is not a feature branch, so we need to release things in order |
ssvegaraju
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.