Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

feat: Validator change #97

Merged
merged 6 commits into from
Jan 21, 2022
Merged

feat: Validator change #97

merged 6 commits into from
Jan 21, 2022

Conversation

Bingjiling
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Add http verb to validator so that we can verify there's no more subscription created if there's already 300 active subscriptions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Bingjiling Bingjiling requested a review from a team as a code owner January 18, 2022 22:09
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (mainline@e8ed9ce). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             mainline      #97   +/-   ##
===========================================
  Coverage            ?   87.14%           
===========================================
  Files               ?        1           
  Lines               ?       70           
  Branches            ?       25           
===========================================
  Hits                ?       61           
  Misses              ?        9           
  Partials            ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8ed9ce...b846f39. Read the comment docs.

carvantes
carvantes reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@carvantes carvantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the HTTP verb needed?

@Bingjiling
Copy link
Contributor Author

  • so that we can verify there's no more subscription created if there's already 300 active subscriptions. We will still allow update, but create will not be allowed it there's already 300 active subscriptions.

@Bingjiling Bingjiling changed the base branch from mainline to feat-subscriptions January 19, 2022 16:32
@github-actions github-actions bot added size/xs and removed size/s labels Jan 19, 2022
carvantes
carvantes suggested changes Jan 20, 2022
View reviewed changes
src/validator.ts Outdated Show resolved Hide resolved
@Bingjiling Bingjiling requested a review from carvantes January 20, 2022 19:51
@Bingjiling Bingjiling merged commit d65165a into feat-subscriptions Jan 21, 2022
@Bingjiling Bingjiling deleted the validator-change branch January 21, 2022 19:28
@carvantes carvantes mentioned this pull request Feb 21, 2022
Merged
carvantes added a commit that referenced this pull request Mar 3, 2022
@carvantes
feat!: add methods to support FHIR Subscriptions (#100)
a980196 
* feat: add getActiveSubscriptions interface (#95)
* feat!: search and validate update for subscription data validation(#94)
* feat: Validator change (#97)

Co-authored-by: Sukeerth Vegaraju <ssvegaraju@yahoo.co.in>
Co-authored-by: Yanyu Zheng <yz2690@columbia.edu>

BREAKING CHANGE: add new required methods `getActiveSubscriptions` and `validateSubscriptionSearchCriteria`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carvantes carvantes carvantes approved these changes

@ssvegaraju ssvegaraju Awaiting requested review from ssvegaraju

Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bingjiling @codecov-commenter @carvantes