Cut v0.3.3 release #674
Merged
Cut v0.3.3 release #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 8621ed8 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/613f999ced5256000818b2d6 😎 Browse the preview: https://deploy-preview-674--karpenter-docs-prod.netlify.app |
JacobGabrielson
approved these changes
Sep 13, 2021
njtran
reviewed
Sep 13, 2021
| @@ -53,7 +53,7 @@ func (t *TopologyGroup) Increment(domain string) { | |||
| // NextDomain chooses a domain that minimizes skew and increments its count | |||
| func (t *TopologyGroup) NextDomain() string { | |||
| minDomain := "" | |||
| minCount := math.MaxInt64 | |||
| minCount := math.MaxInt32 | |||
There was a problem hiding this comment.
Is there a reason we can't do 64 here?
There was a problem hiding this comment.
Yeah -- one of our target releases doesn't have int64 =/. Kind of a lame workaround -- we may need to stop targeting it eventually, but it's out of scope atm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
2. Description of changes:
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.