Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be nice to log the root cause of the error. #653

Open
6 tasks
sdzhangtao opened this issue Nov 21, 2024 · 2 comments
Open
6 tasks

It would be nice to log the root cause of the error. #653

sdzhangtao opened this issue Nov 21, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@sdzhangtao
Copy link

Describe the bug
I am very happy to see the account bootstrap slient failure issue was resolved, now the failure will abort the pipeline, instead of subsequent misleading errors due to accounts not bootstrapped properly.

However, in the error handling, it would be nice to log the error stacktrace. Since it might provide crucial information for debugging and fix the root cause.

The project has mostly followed this pattern anyway.
catch{err: any} {
logger.error(err)
throw new Error("Error description")
}

To Reproduce
Steps to reproduce the behavior.

Expected behavior
A clear and concise description of what you expected to happen.

Please complete the following information about the solution:

  • Version: [e.g. v1.5.1]

To get the version of the solution, you can look at the description of the created AWS CloudFormation stack used to install the LZA (AWSAccelerator-InstallerStack). For example, "(SO0199) Landing Zone Accelerator on AWS. Version 1.5.1.". If the description does not contain the version information, you can look at the Parameters of the stack for the RepositoryBranchName as that should contain the version number.

  • Region: [e.g. us-east-1]
  • Was the solution modified from the version published on this repository?
  • If the answer to the previous question was yes, are the changes available on GitHub?
  • Have you checked your service quotas for the services this solution uses?
  • Were there any errors in the CloudWatch Logs?

Screenshots
If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information).

Additional context
Add any other context about the problem here.

@sdzhangtao sdzhangtao added the bug Something isn't working label Nov 21, 2024
@richardkeit
Copy link
Contributor

Hi @sdzhangtao,
Have you tried updating the solution - the referenced v1.5.1 is over 1 year old at the team has made improvements in that space

@sdzhangtao
Copy link
Author

sdzhangtao commented Nov 21, 2024

Sorry, my bad, didn't update the version from the bug report template. Yes, this applies to latest 1.10.1.
Yes, we had this slient failure with version 1.9.2. Happy to find that slient failure was fixed at 1.10.1, however, it would be nice to log the root cause as well.

If the account bootstrap fails, the root cause will provide crucial information for clients to understand what has caused the failure and remediate the situation. Is it bad payment? Tinted email? Insufficient information? Bad credit? Clients will definitely appreciate the root cause.

Here is the commit of the change.

65fed13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants