Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: actually exclude test files from being installed #1132

Merged
merged 1 commit into from
Sep 19, 2019
Merged

chore: actually exclude test files from being installed #1132

merged 1 commit into from
Sep 19, 2019

Conversation

yan12125
Copy link
Contributor

@yan12125 yan12125 commented Sep 8, 2019

Issue #, if available: N/A

Description of changes:

In Arch Linux, we build python-aws-sam-translator package from sources. Before this change, test files are installed:

$ python setup.py install --root=arch-pkgdir
$ ls arch-pkgdir/usr/lib/python3.7/site-packages/tests
intrinsics  model  plugins  policy_template_processor  sdk  swagger  translator

This is a problem as the directory /usr/lib/python3.7/site-packages/tests conflicts with other packages.

Description of how you validated changes:

After this change, there are no longer test files

$ python setup.py install --root=arch-pkgdir
$ ls arch-pkgdir/usr/lib/python3.7/site-packages
aws_sam_translator-1.15.0-py3.7.egg-info  samtranslator

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

I think these checks are irrelevant are this is a packaging fix.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #1132 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #1132   +/-   ##
=======================================
  Coverage     94.8%   94.8%           
=======================================
  Files           71      71           
  Lines         3486    3486           
  Branches       680     680           
=======================================
  Hits          3305    3305           
  Misses          93      93           
  Partials        88      88

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc85fb...93312b6. Read the comment docs.

@praneetap praneetap assigned jlhood and unassigned praneetap Sep 19, 2019
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@jlhood jlhood merged commit 91adf57 into aws:develop Sep 19, 2019
@yan12125 yan12125 deleted the exclude-tests branch September 19, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants