Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Greengrass Hello World examples #1191

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

hui-yang
Copy link
Contributor

Issue #, if available:

Description of changes:

  1. Greengrass Hello World NodeJS
    1. Migrate to Node8
    2. Add Greengrass Core SDK v1.4.0
  2. Greengrass Hello World Python
    1. Migrate to Python3.7
    2. Update Greengrass Core SDK v1.4.0
    3. Remove Greengrass Commons and Greengrass IPC SDK, because these should be provided by Greengrass Core.

Description of how you validated changes:
End-to-end test with Greengrass v1.9.3.

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Oct 10, 2019

Codecov Report

Merging #1191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1191   +/-   ##
=======================================
  Coverage   94.36%   94.36%           
=======================================
  Files          71       71           
  Lines        3621     3621           
  Branches      713      713           
=======================================
  Hits         3417     3417           
  Misses        104      104           
  Partials      100      100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd587c...631a3c5. Read the comment docs.

@keetonian keetonian changed the base branch from master to develop October 10, 2019 17:56
@keetonian keetonian self-assigned this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants