Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sns publish #1200

Merged
merged 1 commit into from
Oct 15, 2019
Merged

fix sns publish #1200

merged 1 commit into from
Oct 15, 2019

Conversation

pfeilbr
Copy link
Contributor

@pfeilbr pfeilbr commented Oct 14, 2019

fix sns publish. was using sqs. from aws sqs send-message to aws sns publish

Issue #, if available:

Description of changes:

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@53ningen 53ningen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my mistake(#1065).
Thank you for fixing it.

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@jlhood jlhood changed the base branch from master to develop October 14, 2019 23:34
fix sns publish.  was using sqs.  from `aws sqs send-message` to `aws sns publish`
@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #1200 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1200      +/-   ##
===========================================
+ Coverage    94.33%   94.36%   +0.03%     
===========================================
  Files           72       71       -1     
  Lines         3725     3621     -104     
  Branches       733      713      -20     
===========================================
- Hits          3514     3417      -97     
+ Misses         107      104       -3     
+ Partials       104      100       -4
Impacted Files Coverage Δ
samtranslator/plugins/api/implicit_api_plugin.py 96.47% <0%> (-2.12%) ⬇️
samtranslator/model/apigateway.py 97.79% <0%> (-0.12%) ⬇️
samtranslator/model/sam_resources.py 95.49% <0%> (-0.1%) ⬇️
samtranslator/model/eventsources/push.py 89.49% <0%> (-0.03%) ⬇️
samtranslator/plugins/globals/globals_plugin.py 100% <0%> (ø) ⬆️
samtranslator/model/events.py 85.71% <0%> (ø) ⬆️
samtranslator/translator/verify_logical_id.py 100% <0%> (ø) ⬆️
samtranslator/plugins/globals/globals.py 99.02% <0%> (ø) ⬆️
samtranslator/model/route53.py
samtranslator/model/api/api_generator.py 96.72% <0%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0ec0b7...f4a9df3. Read the comment docs.

Copy link

@ShreyaGangishetty ShreyaGangishetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this !

@ShreyaGangishetty ShreyaGangishetty merged commit 666235c into aws:develop Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants