-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sns publish #1200
fix sns publish #1200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's my mistake(#1065).
Thank you for fixing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
fix sns publish. was using sqs. from `aws sqs send-message` to `aws sns publish`
Codecov Report
@@ Coverage Diff @@
## develop #1200 +/- ##
===========================================
+ Coverage 94.33% 94.36% +0.03%
===========================================
Files 72 71 -1
Lines 3725 3621 -104
Branches 733 713 -20
===========================================
- Hits 3514 3417 -97
+ Misses 107 104 -3
+ Partials 104 100 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this !
fix sns publish. was using sqs. from
aws sqs send-message
toaws sns publish
Issue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.