-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow kinesis:DescribeStreamSummary for KinesisCrudPolicy and KinesisReadStreamPolicy #1259
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1259 +/- ##
===========================================
+ Coverage 94.49% 95.26% +0.76%
===========================================
Files 72 72
Lines 3745 4373 +628
Branches 741 1003 +262
===========================================
+ Hits 3539 4166 +627
Misses 104 104
- Partials 102 103 +1
Continue to review full report at Codecov.
|
"version": "1.3.1", | ||
"resolved": "https://registry.npmjs.org/mixin-deep/-/mixin-deep-1.3.1.tgz", | ||
"integrity": "sha512-8ZItLHeEgaqEvd5lYBXfm4EZSFCX29Jb9K+lAHhDKzReKBQKj3R+7NOF6tjqYi9t4oI8VUfaWITJQm86wnXGNQ==", | ||
"version": "1.3.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaeljfazio Could you please update this PR by removing this commit from this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased back off the release tag now to avoid picking up the change that introduced it. Should be good to go now.
…StreamReadPolicy Resolves issue aws#1251
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaeljfazio Thank you for contributing this!! This PR looks good to me
Resolves issue #1251
Added kinesis:DescribeStreamSummary action to KinesisCrudPolicy and KinesisReadStreamPolicy
Validated via unit test.
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.