Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow kinesis:DescribeStreamSummary for KinesisCrudPolicy and KinesisReadStreamPolicy #1259

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

michaeljfazio
Copy link
Contributor

@michaeljfazio michaeljfazio commented Nov 22, 2019

Resolves issue #1251

Added kinesis:DescribeStreamSummary action to KinesisCrudPolicy and KinesisReadStreamPolicy

Validated via unit test.

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #1259 into develop will increase coverage by 0.76%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1259      +/-   ##
===========================================
+ Coverage    94.49%   95.26%   +0.76%     
===========================================
  Files           72       72              
  Lines         3745     4373     +628     
  Branches       741     1003     +262     
===========================================
+ Hits          3539     4166     +627     
  Misses         104      104              
- Partials       102      103       +1
Impacted Files Coverage Δ
samtranslator/model/events.py 75% <0%> (-10.72%) ⬇️
samtranslator/model/iam.py 76.92% <0%> (-4.33%) ⬇️
samtranslator/model/lambda_.py 87.5% <0%> (-0.97%) ⬇️
samtranslator/plugins/api/implicit_api_plugin.py 98.43% <0%> (-0.18%) ⬇️
...nslator/model/preferences/deployment_preference.py 100% <0%> (ø) ⬆️
samtranslator/plugins/globals/globals_plugin.py 100% <0%> (ø) ⬆️
samtranslator/translator/verify_logical_id.py 100% <0%> (ø) ⬆️
samtranslator/model/codedeploy.py 100% <0%> (ø) ⬆️
samtranslator/model/sam_resources.py 95.93% <0%> (+0.28%) ⬆️
samtranslator/model/apigateway.py 98.43% <0%> (+0.53%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31e880...a44d1e0. Read the comment docs.

@praneetap praneetap changed the base branch from master to develop November 27, 2019 19:21
"version": "1.3.1",
"resolved": "https://registry.npmjs.org/mixin-deep/-/mixin-deep-1.3.1.tgz",
"integrity": "sha512-8ZItLHeEgaqEvd5lYBXfm4EZSFCX29Jb9K+lAHhDKzReKBQKj3R+7NOF6tjqYi9t4oI8VUfaWITJQm86wnXGNQ==",
"version": "1.3.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaeljfazio Could you please update this PR by removing this commit from this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased back off the release tag now to avoid picking up the change that introduced it. Should be good to go now.

Copy link

@ShreyaGangishetty ShreyaGangishetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaeljfazio Thank you for contributing this!! This PR looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants