Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependabot resolution for got package #1008

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Conversation

SanketD92
Copy link
Contributor

@SanketD92 SanketD92 commented Jul 1, 2022

Issue #, if available:
https://github.com/awslabs/service-workbench-on-aws/security/dependabot/38

Description of changes:
Resolution for got package

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?
  • If new dependencies have been added, have they been pinned to specific versions?
  • Is this change also required on the AWS Solution version?
  • Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)?
  • If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests?
  • If you are updating the changelog and vending out a new release, have you updated versionNumber and versionDate in .defaults.yml

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SanketD92 SanketD92 requested a review from a team as a code owner July 1, 2022 19:13
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1008 (ae8f13e) into develop (d8eb14f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1008   +/-   ##
========================================
  Coverage    51.70%   51.70%           
========================================
  Files          295      295           
  Lines        16895    16895           
  Branches      2629     2629           
========================================
  Hits          8735     8735           
  Misses        7170     7170           
  Partials       990      990           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8eb14f...ae8f13e. Read the comment docs.

@SanketD92 SanketD92 merged commit 8619c6e into develop Jul 1, 2022
@SanketD92 SanketD92 deleted the fix-dependabot-got branch July 1, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants