fix: tre egress store data updated S3 return #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanketD92
approved these changes
Oct 12, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1054 +/- ##
===========================================
+ Coverage 51.93% 59.56% +7.62%
===========================================
Files 238 126 -112
Lines 14508 9224 -5284
Branches 2361 1475 -886
===========================================
- Hits 7535 5494 -2041
+ Misses 6106 3288 -2818
+ Partials 867 442 -425
Continue to review full report at Codecov.
|
pbabz
reviewed
Oct 12, 2022
| @@ -70,6 +70,7 @@ describe('Create URL scenarios', () => { | |||
| StorageClass: 'STANDARD', | |||
| projectId: 'TRE-Project', | |||
| workspaceId: 'ea8e5286-45ca-402a-8c98-7d4495f646e2', | |||
| ChecksumAlgorithm: [], // new attribute introduced in Feb 2022 https://aws.amazon.com/blogs/aws/new-additional-checksum-algorithms-for-amazon-s3/ | |||
There was a problem hiding this comment.
I don't think the comment is necessary
There was a problem hiding this comment.
Sanket suggested it so people that look at this test later know why it was needed.
pbabz
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
S3 introduced a new attribute in their
listObjectsV2method that contains the checksum algorithm for S3 objects in Feb 2022. The test did not expect the attribute. The attribute is empty as we are not specifying a checksum algorithm duringputcalls.Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.