Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Service Workbench installation guide #545

Merged
merged 11 commits into from
Jun 22, 2021
Merged

Conversation

shyogesh-sw
Copy link
Contributor

Issue #, if available: GALI-988

Description of changes: New Service Workbench installation guide

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?
  • If new dependencies have been added, have they been pinned to specific versions?
  • Is this change also required on the AWS Solution version?
  • Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)?
  • If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@shyogesh-sw shyogesh-sw requested a review from a team as a code owner June 22, 2021 17:27
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #545 (4d961b8) into develop (b202080) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #545   +/-   ##
========================================
  Coverage    49.04%   49.04%           
========================================
  Files          243      243           
  Lines        12503    12503           
  Branches      2014     2014           
========================================
  Hits          6132     6132           
  Misses        5564     5564           
  Partials       807      807           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b202080...4d961b8. Read the comment docs.

Copy link
Contributor

@SanketD92 SanketD92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shyogesh-sw shyogesh-sw merged commit 2be27d1 into develop Jun 22, 2021
@shyogesh-sw shyogesh-sw deleted the install-guide branch June 22, 2021 19:28
@shyogesh-sw
Copy link
Contributor Author

The new SWB installation guide is now published.

jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
* <docs: added hyperlinks in packer readme>

* Revert "<docs: added hyperlinks in packer readme>"

This reverts commit 501b7de.

* docs: new installation guide

* docs: new installation guide

* docs: added hyperlinks in architecture topic

Co-authored-by: Sanket Dharwadkar <sdharwad@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants