fix: AppDeployer needs perms to create new env #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #762 +/- ##
========================================
Coverage 52.09% 52.09%
========================================
Files 272 272
Lines 14519 14519
Branches 2285 2285
========================================
Hits 7563 7563
Misses 6106 6106
Partials 850 850 Continue to review full report at Codecov.
|
nguyen102
approved these changes
Oct 19, 2021
jxuamazon
pushed a commit
to jxuamazon/service-workbench-on-aws
that referenced
this pull request
Feb 15, 2022
* fix: AppDeployer needs perms to create new env * fix: AppDeployer specific changes only * removing unrelated changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
AppDeployer role was lacking permissions for creating a new SWB environment.
Description of changes:
Permissions needed were around being able to pass the AppDeployer role to SWB CFN stacks.
Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.