Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable versioning #780

Merged
merged 2 commits into from
Oct 28, 2021
Merged

fix: enable versioning #780

merged 2 commits into from
Oct 28, 2021

Conversation

maghirardelli
Copy link
Contributor

Issue #, if available: GALI-1202

Description of changes: enable versioning on buckets within cloudformation templates. To test that this didn't disrupt the functionality, I deployed these changes in a TRE and non-TRE environment and connected to workspaces with studies in both.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #780 (8be4239) into develop (d19124c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #780   +/-   ##
========================================
  Coverage    52.10%   52.10%           
========================================
  Files          272      272           
  Lines        14522    14522           
  Branches      2284     2285    +1     
========================================
  Hits          7566     7566           
  Misses        6106     6106           
  Partials       850      850           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d19124c...8be4239. Read the comment docs.

Copy link
Contributor

@nguyen102 nguyen102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think these changes shouldn't cause any issues, but just to confirm, I would run some manual testing with launching workspaces and attaching studies. Confirm that everything still works as expected.

@maghirardelli
Copy link
Contributor Author

I tested in both a TRE and non TRE environment that I can create studies, launch workspaces attached to those studies, and access the contents of those study folders.

@maghirardelli maghirardelli merged commit 380a938 into develop Oct 28, 2021
@maghirardelli maghirardelli deleted the fix-versioning branch October 28, 2021 19:09
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants