-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updates to RStudio Integration tests #818
fix: Updates to RStudio Integration tests #818
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #818 +/- ##
========================================
Coverage 50.91% 50.91%
========================================
Files 286 286
Lines 15931 15931
Branches 2485 2485
========================================
Hits 8111 8111
Misses 6863 6863
Partials 957 957 Continue to review full report at Codecov.
|
b41973a
Note: Before we can merge this PR in, we need to refactor the Cypress AppStream disabled workspace test to terminate workspaces that it launches. This is because the RStudio Integration test checks that all RStudio instances are terminated, before it runs. An example of how to refactor the Cypress AppStream disabled workspace tests. |
Terminated RStudio instances manually on the e2e test environment. PR for automatic termination depends on this PR merge. |
* chore: Remove extraneous comments from launch-rstudio-workspace.test.js * fix: Don't run rstudio tests if rstudio config is 'N/A' * Move advanced tests into common folder so they get executed * Fix import path Co-authored-by: Tim Nguyen <thingut@amazon.com>
Issue #, if available:
Description of changes:
Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.