-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change build-image CLI argument to files #825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide more details as to what didn't work earlier with the "file" argument?
Codecov Report
@@ Coverage Diff @@
## develop #825 +/- ##
========================================
Coverage 50.91% 50.91%
========================================
Files 286 286
Lines 15931 15931
Branches 2485 2485
========================================
Hits 8111 8111
Misses 6863 6863
Partials 957 957 Continue to review full report at Codecov.
|
As far as I could tell it it does nothing. An argument like |
Was able to verify the Please pull the latest changes from |
* fix: Change build-image CLI argument to files Co-authored-by: Liam Coatman <liam.c@faculty.ai>
Issue #, if available:
Description of changes:
Change argument name from
file
tofiles
, which is what is read on lines 56 and 58. I've tested this manually and verified that only machine imagefoo
is built when I runpnpx sls build-image --files foo.json -s dev
.Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.