Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add key rotation #834

Merged
merged 9 commits into from
Dec 15, 2021
Merged

fix: add key rotation #834

merged 9 commits into from
Dec 15, 2021

Conversation

maghirardelli
Copy link
Contributor

Issue #, if available: GALI-1203

Description of changes: turning key rotation on for all remaining keys not already turned on. Verified that it was not on before changes and on afterwards.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you successfully tested with your changes locally?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #834 (bf2c67a) into develop (78b58c5) will decrease coverage by 11.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #834       +/-   ##
============================================
- Coverage    50.91%   39.79%   -11.12%     
============================================
  Files          286      218       -68     
  Lines        15931    10011     -5920     
  Branches      2484     1496      -988     
============================================
- Hits          8111     3984     -4127     
+ Misses        6863     5301     -1562     
+ Partials       957      726      -231     
Impacted Files Coverage Δ
lib/user/user-authz-service.js 24.07% <0.00%> (-52.40%) ⬇️
lib/helpers/utils.js 21.21% <0.00%> (-43.75%) ⬇️
lib/user/user-service.js 64.93% <0.00%> (-2.18%) ⬇️
lib/compute/data/emr/configurations.js
lib/compute/compute-price-service.js
lib/cost-api-cache/cost-api-cache-service.js
lib/user/helpers/user-authz-utils.js
lib/project/project-service.js
lib/user-roles/user-roles-service.js
lib/plugins/env-provisioning-plugin.js
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b58c5...bf2c67a. Read the comment docs.

@maghirardelli maghirardelli merged commit 46bfa83 into develop Dec 15, 2021
@maghirardelli maghirardelli deleted the fix-key-rotation branch December 15, 2021 19:05
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants