-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add key rotation #834
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maghirardelli
requested review from
nguyen102,
Bingjiling,
SanketD92 and
jn1119
December 15, 2021 18:05
Codecov Report
@@ Coverage Diff @@
## develop #834 +/- ##
============================================
- Coverage 50.91% 39.79% -11.12%
============================================
Files 286 218 -68
Lines 15931 10011 -5920
Branches 2484 1496 -988
============================================
- Hits 8111 3984 -4127
+ Misses 6863 5301 -1562
+ Partials 957 726 -231
Continue to review full report at Codecov.
|
jn1119
approved these changes
Dec 15, 2021
jxuamazon
pushed a commit
to jxuamazon/service-workbench-on-aws
that referenced
this pull request
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: GALI-1203
Description of changes: turning key rotation on for all remaining keys not already turned on. Verified that it was not on before changes and on afterwards.
Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.