Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: elb logging on #843

Merged
merged 12 commits into from
Dec 20, 2021
Merged

fix: elb logging on #843

merged 12 commits into from
Dec 20, 2021

Conversation

maghirardelli
Copy link
Contributor

Issue #, if available: GALI-1330

Description of changes: turn on ELB logging for each ALB provisioned. This change does require users to update permissions of member accounts for it to work. It is NOT a breaking change. Additionally, only new ALBs will have logging on. So, for users to see the effect of this change, they need to update the permissions of their member accounts in the SWB Console and terminate all RStudio workspaces (which will delete all existing ALBs). If users decide not to do this, their workspaces (RStudio and others) will continue to work, but they will not have logging on for new RStudio workspaces on existing ALBs.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #843 (1e11b13) into develop (f222f06) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #843   +/-   ##
========================================
  Coverage    50.91%   50.91%           
========================================
  Files          286      286           
  Lines        15931    15932    +1     
  Branches      2483     2483           
========================================
+ Hits          8111     8112    +1     
  Misses        6863     6863           
  Partials       957      957           
Impacted Files Coverage Δ
lib/alb/alb-service.js 73.80% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f222f06...1e11b13. Read the comment docs.

@maghirardelli maghirardelli merged commit 163b411 into develop Dec 20, 2021
@maghirardelli maghirardelli deleted the fix-elb-logging branch December 20, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants