-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: elb logging on #843
Merged
Merged
fix: elb logging on #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maghirardelli
requested review from
nguyen102,
Bingjiling,
SanketD92 and
jn1119
December 20, 2021 20:12
Codecov Report
@@ Coverage Diff @@
## develop #843 +/- ##
========================================
Coverage 50.91% 50.91%
========================================
Files 286 286
Lines 15931 15932 +1
Branches 2483 2483
========================================
+ Hits 8111 8112 +1
Misses 6863 6863
Partials 957 957
Continue to review full report at Codecov.
|
SanketD92
reviewed
Dec 20, 2021
nguyen102
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: GALI-1330
Description of changes: turn on ELB logging for each ALB provisioned. This change does require users to update permissions of member accounts for it to work. It is NOT a breaking change. Additionally, only new ALBs will have logging on. So, for users to see the effect of this change, they need to update the permissions of their member accounts in the SWB Console and terminate all RStudio workspaces (which will delete all existing ALBs). If users decide not to do this, their workspaces (RStudio and others) will continue to work, but they will not have logging on for new RStudio workspaces on existing ALBs.
Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.