Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow CICD pipeline to have cognito permission for creating root user #914

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

nguyen102
Copy link
Contributor

Issue #, if available:

Description of changesfix:

Allow CICD pipeline to have cognito permission for creating root user

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?
  • If new dependencies have been added, have they been pinned to specific versions?
  • Is this change also required on the AWS Solution version?
  • Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)?
  • If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests?
  • If you are updating the changelog and vending out a new release, have you updated versionNumber and versionDate in .defaults.yml

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nguyen102 nguyen102 requested a review from a team as a code owner February 9, 2022 17:33
SanketD92
SanketD92 previously approved these changes Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #914 (df2a3f8) into develop (86c6e19) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #914   +/-   ##
========================================
  Coverage    51.71%   51.71%           
========================================
  Files          293      293           
  Lines        16597    16597           
  Branches      2569     2569           
========================================
  Hits          8583     8583           
  Misses        7046     7046           
  Partials       968      968           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c6e19...df2a3f8. Read the comment docs.

@nguyen102 nguyen102 merged commit 93618cb into awslabs:develop Feb 10, 2022
@nguyen102 nguyen102 deleted the internal-auth-dep-fixes branch June 5, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants