Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select cidr field only in non-TRE env #941

Merged
merged 5 commits into from
Mar 3, 2022

Conversation

SanketD92
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:
Compute UI errors for CIDR only in non-TRE environments.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you successfully tested with your changes locally?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SanketD92 SanketD92 requested a review from nguyen102 March 3, 2022 21:07
@SanketD92 SanketD92 requested a review from a team as a code owner March 3, 2022 21:07
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #941 (8ad3c51) into develop (dd2ccfd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #941   +/-   ##
========================================
  Coverage    51.44%   51.44%           
========================================
  Files          295      295           
  Lines        16784    16784           
  Branches      2596     2596           
========================================
  Hits          8634     8634           
  Misses        7163     7163           
  Partials       987      987           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2ccfd...8ad3c51. Read the comment docs.

@SanketD92 SanketD92 merged commit 897670b into develop Mar 3, 2022
@SanketD92 SanketD92 deleted the fix-selected-field-undefined branch March 3, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants