Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return badRequest if trying to terminate an environment that has already been terminated #946

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

nguyen102
Copy link
Contributor

@nguyen102 nguyen102 commented Mar 8, 2022

Issue #, if available:

Description of changes:
If an environment is in the TERMINATED, TERMINATING, or TERMINATING_FAILED status and a request is made to terminate the environment, return an HTTP Status Code 400 error.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nguyen102 nguyen102 requested a review from a team as a code owner March 8, 2022 21:52
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #946 (d8dd26d) into develop (99cc33b) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #946      +/-   ##
===========================================
+ Coverage    51.44%   51.45%   +0.01%     
===========================================
  Files          295      295              
  Lines        16784    16790       +6     
  Branches      2596     2599       +3     
===========================================
+ Hits          8634     8640       +6     
  Misses        7163     7163              
  Partials       987      987              
Impacted Files Coverage Δ
...ironment/service-catalog/environment-sc-service.js 70.46% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99cc33b...d8dd26d. Read the comment docs.

Copy link
Contributor

@maghirardelli maghirardelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nguyen102 nguyen102 merged commit 15eb4d3 into awslabs:develop Mar 9, 2022
@nguyen102 nguyen102 deleted the terminate-failure branch June 5, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants