Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use correct colour for pending workspace display (#968) #969

Merged
merged 3 commits into from
Apr 20, 2022
Merged

chore: Use correct colour for pending workspace display (#968) #969

merged 3 commits into from
Apr 20, 2022

Conversation

tdmalone
Copy link
Contributor

Closes #968

Description of changes:

Checklist:

  • Have you successfully deployed to an AWS account with your changes?

  • Have you successfully tested with your changes locally?

    NOTE: Testing was only done locally in the browser console, to confirm that the class applied successfully and looked as expected:
    image
    image

  • Is this change also required on the AWS Solution version?

  • If you are updating the changelog and vending out a new release, have you updated versionNumber and versionDate in .defaults.yml

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tdmalone tdmalone requested a review from a team as a code owner April 14, 2022 03:43
@tdmalone tdmalone changed the base branch from mainline to develop April 14, 2022 03:46
@Bingjiling Bingjiling changed the title fix: Use correct colour for pending workspace display (#968) chore: Use correct colour for pending workspace display (#968) Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #969 (db5c4c3) into develop (24010d3) will not change coverage.
The diff coverage is n/a.

❗ Current head db5c4c3 differs from pull request most recent head cfdb121. Consider uploading reports for the commit cfdb121 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #969   +/-   ##
========================================
  Coverage    51.40%   51.40%           
========================================
  Files          295      295           
  Lines        16821    16821           
  Branches      2611     2611           
========================================
  Hits          8647     8647           
  Misses        7183     7183           
  Partials       991      991           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24010d3...cfdb121. Read the comment docs.

Copy link
Contributor

@nguyen102 nguyen102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it works as expected. Thank you for your contribution!

@nguyen102 nguyen102 merged commit 9f694dc into awslabs:develop Apr 20, 2022
@tdmalone tdmalone deleted the fix-pending-colour branch April 21, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Minor: pending workspace background colour is incorrect
2 participants