Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #522

Merged
merged 23 commits into from
Jun 9, 2021
Merged

Develop #522

merged 23 commits into from
Jun 9, 2021

Conversation

nguyen102
Copy link
Contributor

Issue #, if available:

Description of changes:
Merging develop into feat-secure-workspace-egress branch to sync the two branches up.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nguyen102 and others added 23 commits May 13, 2021 15:09
* fix: bug in openapi.yaml introduced in previous PR with unescaped asterisk causing malformed YAML file
* fix: adds validation checks and more informative error messages for bulk-add-users API call.
* fix: added unit and integration tests for changes
* chore: Update issue templates

* Trigger notification

* fix: changes per review

Co-authored-by: Robert Smayda <smayda44@gmail.com>
* <docs: added hyperlinks in packer readme>

* Revert "<docs: added hyperlinks in packer readme>"

This reverts commit 501b7de.

* docs: corrected the hyperlinks
* chore(deps): bump dns-packet from 1.3.1 to 1.3.4 in /docs

Bumps [dns-packet](https://github.com/mafintosh/dns-packet) from 1.3.1 to 1.3.4.
- [Release notes](https://github.com/mafintosh/dns-packet/releases)
- [Changelog](https://github.com/mafintosh/dns-packet/blob/master/CHANGELOG.md)
- [Commits](mafintosh/dns-packet@v1.3.1...v1.3.4)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Tim Nguyen <thingut@amazon.com>
Co-authored-by: Tim Nguyen <thingut@amazon.com>
@nguyen102 nguyen102 requested a review from a team as a code owner June 9, 2021 20:09
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #522 (ea2650f) into feat-secure-workspace-egress (0a4328e) will increase coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           feat-secure-workspace-egress     #522      +/-   ##
================================================================
+ Coverage                         48.36%   49.04%   +0.67%     
================================================================
  Files                               243      243              
  Lines                             12474    12503      +29     
  Branches                           2008     2012       +4     
================================================================
+ Hits                               6033     6132      +99     
+ Misses                             5622     5564      -58     
+ Partials                            819      807      -12     
Impacted Files Coverage Δ
src/parts/studies/StudyPermissionsTable.js 1.63% <0.00%> (-0.06%) ⬇️
src/parts/studies/StudiesPage.js 75.64% <0.00%> (ø)
...ironment/service-catalog/environment-sc-service.js 71.25% <0.00%> (+0.67%) ⬆️
lib/user/user-service.js 62.28% <0.00%> (+2.46%) ⬆️
lib/authorization/assertions.js 47.61% <0.00%> (+28.57%) ⬆️
src/models/users/User.js 52.83% <0.00%> (+44.17%) ⬆️
lib/db-password/db-password-service.js 63.15% <0.00%> (+46.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a4328e...ea2650f. Read the comment docs.

Copy link
Contributor

@MBtea MBtea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, updating the feat branch with dev branch commits.

@MBtea MBtea merged commit 81b9423 into feat-secure-workspace-egress Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants