Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Corrected Spark defaults to fix read/write functionality from Spark #526

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

jn1119
Copy link
Contributor

@jn1119 jn1119 commented Jun 10, 2021

Issue #, if available: Issue 496 and Issue 495

Description of changes: See Issue 496 and Issue 495 for details.

  • Removing is.hail.io.compress.BGzipCodec since Hail isn't setup correctly
  • For Parquet- the main issue was parquet block size config which was defaulted to 1 TB and therefore was failing file writing. I have changed block size and other defaults to same as what Spark uses internally

Testing

  • Deployed the change, imported the new SC template and provisioned EMR. Verified that read/write functionality and parquet writes specifically now work. Also verified that defaults are now updated correctly.

image

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?
  • If new dependencies have been added, have they been pinned to specific versions?
  • Is this change also required on the AWS Solution version?
  • Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)?
  • If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jn1119 jn1119 requested a review from nguyen102 June 10, 2021 21:15
@jn1119 jn1119 requested a review from a team as a code owner June 10, 2021 21:15
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #526 (4fa845a) into develop (ea2650f) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #526      +/-   ##
===========================================
+ Coverage    49.01%   49.04%   +0.03%     
===========================================
  Files          243      243              
  Lines        12597    12503      -94     
  Branches      2032     2012      -20     
===========================================
- Hits          6174     6132      -42     
+ Misses        5606     5564      -42     
+ Partials       817      807      -10     
Impacted Files Coverage Δ
src/models/aws-accounts/AwsAccountsStore.js 54.54% <0.00%> (-13.93%) ⬇️
src/models/aws-accounts/AwsAccount.js 16.66% <0.00%> (-1.86%) ⬇️
src/helpers/api.js 0.96% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea2650f...4fa845a. Read the comment docs.

@jn1119 jn1119 merged commit f96e1bd into awslabs:develop Jun 10, 2021
ahl27 added a commit that referenced this pull request Jun 11, 2021
* feature: updated UI for AWS accounts page with cards instead of a list box.

* feature: added API calls to update AWS Account, added functionality to check permissions status and update with DB table on backend

* feat: adds filter buttons for accounts as well as code cleanup and general UX improvements.

* fix: fixed budget buttons on account cards to correctly direct to the budget page

* fix: cleaned up code, added unit test, added entry to openapi.yaml

* fix: removed unused file

* fix: made some buttons look better

* fix: added unit test to increase codecov and fixed a minor bug in AwsAccountsStore

* chore: docs dependency fix (#505)

* chore(deps): bump dns-packet from 1.3.1 to 1.3.4 in /docs (#507)

* chore(deps): bump dns-packet from 1.3.1 to 1.3.4 in /docs

Bumps [dns-packet](https://github.com/mafintosh/dns-packet) from 1.3.1 to 1.3.4.
- [Release notes](https://github.com/mafintosh/dns-packet/releases)
- [Changelog](https://github.com/mafintosh/dns-packet/blob/master/CHANGELOG.md)
- [Commits](mafintosh/dns-packet@v1.3.1...v1.3.4)

Signed-off-by: dependabot[bot] <support@github.com>

* fix: trigger build

* feat: Add warning that internal authentication shouldn't be used in production (#506)

* feat: Encrypt s3 buckets for EMR log bucket and CICD Artifact bucket (#508)

* chore: Disable EBS volume for storage gateway (#511)

Co-authored-by: Tim Nguyen <thingut@amazon.com>

* fix: changes suggested by Yanyu in CR

* fix: minor change to openapi.yml

* fix: removed unneccessary script

* fix: removed reliance on undefined value for needsPermissionUpdate

* fix: changed NEW to ONBOARDME for better clarity

* Update settings.json

* Update settings.json

* removed confusing half-implemented function and replaced with placeholder

* chore: Add encryption to CICD SNS topic (#512)

Co-authored-by: Tim Nguyen <thingut@amazon.com>

* fix: Allow sagemaker to have the proper IAM permission to autostop itself (#515)

* chore: Enable access logging for env-type-configs bucket (#520)

* chore: Enable server side encryption on prepare master and edge lambda bucket (#521)

* fix: Corrected Spark defaults to fix read/write functionality from Spark (#526)

Co-authored-by: Yanyu Zheng <yz2690@columbia.edu>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tim Nguyen <nguyen102@users.noreply.github.com>
Co-authored-by: Tim Nguyen <thingut@amazon.com>
Co-authored-by: Jeet <68876606+jn1119@users.noreply.github.com>
manikandan-thangavelu-rl pushed a commit to RLOpenCatalyst/service-workbench-on-aws that referenced this pull request Jun 14, 2021
manikandan-thangavelu-rl added a commit to RLOpenCatalyst/service-workbench-on-aws that referenced this pull request Jun 14, 2021
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants