Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add provision account unit test #572

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
49bb5c0
Working offline sagemaker
Jun 23, 2021
123b2d2
Working linux ec2
Jun 25, 2021
92d1144
Working windows
Jun 25, 2021
02acfa2
Add offline packages
Jun 28, 2021
7957c2b
Cleanup
Jun 28, 2021
bbf8824
Add isAppStreamEnabled param and SolutionNamespace param
Jun 28, 2021
d1ad641
Move packages
Jun 28, 2021
43da77a
Merge branch 'feat-secure-workspace-egress' into workspace-remove-int…
Jun 28, 2021
2d3be6b
Allow unit tests to run
Jun 28, 2021
1615df3
Add IsAppStreamEnabled param for templates
Jun 30, 2021
b742a6c
Add isAppStreamEnabled and solutionNamespace to resolved var params
Jun 30, 2021
d29e1b9
Working connect to ec2 instance from AppStream
Jul 1, 2021
619a724
Update environment-config-vars-service-test
Jul 1, 2021
d12606a
Fixing window stack
Jul 1, 2021
a87ec81
Merge branch 'feat-secure-workspace-egress' into workspace-remove-int…
Jul 1, 2021
3e2481f
WIP, app stream account onboard
Jul 1, 2021
adb9f3a
Update AppStream setup
Jul 2, 2021
3019b0b
Merge branch 'workspace-remove-internet' into appstream-onboard-api
Jul 2, 2021
737a690
Remove code accidentally added to the PR
Jul 2, 2021
1cb5ede
Delete duplicate isAppStreamEnabled value
Jul 2, 2021
c1e75dc
WIP: UI part
Jul 2, 2021
da512e8
WIP
Jul 6, 2021
2b8dae6
Working
Jul 7, 2021
e15e2c9
Working end to end
Jul 7, 2021
900f28e
Some cleanup
Jul 7, 2021
26628b1
Merge branch 'feat-secure-workspace-egress' into appstream-onboard-api
Jul 8, 2021
5824414
Update lock file
Jul 8, 2021
9959846
Update tests
Jul 9, 2021
741b50f
Update CFN permission for images
Jul 9, 2021
8ba2441
Remove duplicate export in onboard-account
Jul 9, 2021
7a71da0
Start fleet
Jul 9, 2021
af43236
Automatically create AppStream roles
Jul 12, 2021
32dc77f
Wait for AppStream fleet to transition to RUNNING state before comple…
Jul 12, 2021
173d0b6
Need to pass in default value for when AppStream not enabled
Jul 12, 2021
e93aed8
Add provision-account.test.ts
Jul 13, 2021
5bf28d0
Merge branch 'appstream-onboard-api' into provision-account-unit-test
Jul 13, 2021
a946b6a
Update
Jul 14, 2021
ae08543
Merge branch 'feat-secure-workspace-egress' into provision-account-un…
Jul 15, 2021
d1b174c
Revert accidentally delete comments
Jul 15, 2021
5e89f23
Add createAppStreamRoles test and shareImageWithMemberAccount test
Jul 15, 2021
016b1be
Update
Jul 15, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,21 @@ class EnvironmentConfigVarsService extends Service {
});
}

// TODO: If the ami sharing gets moved (because it doesn't contribute to an env var)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment section was accidentally removed in this PR.
Adding it back

// then move the update local resource policies too.
// Using the account root provides basically the same level of security because in either
// case we have to trust that the member account hasn't altered the role's assume role policy to allow other
// principals assume it
// if (s3Prefixes.length > 0) {
// await environmentMountService.addRoleArnToLocalResourcePolicies(`arn:aws:iam::${accountId}:root`, s3Prefixes);
// }

// Check if the environment being launched needs an admin key-pair to be created in the target account
// If the configuration being used has any parameter that uses the "adminKeyPairName" variable then it means
// we need to provision that key in the target account and provide the name of the generated key as the
// "adminKeyPairName" variable
// Disabling "no-template-curly-in-string" lint rule because we need to compare with the string literal "${adminKeyPairName}"
// i.e., without any string interpolation
// eslint-disable-next-line no-template-curly-in-string
const isAdminKeyPairRequired = !!_.find(envTypeConfig.params, p => p.value === '${adminKeyPairName}');
let adminKeyPairName = '';
Expand Down
Loading