-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Added details found needed while onboarding #593
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #593 +/- ##
========================================
Coverage 49.07% 49.07%
========================================
Files 244 244
Lines 12543 12543
Branches 2016 2015 -1
========================================
Hits 6155 6155
Misses 5581 5581
Partials 807 807 Continue to review full report at Codecov.
|
@@ -12,6 +12,8 @@ To run the E2E tests, you will need the following items: | |||
- Username and password of an admin for the Service Workbench environment | |||
- Username and password of a researcher for the Service Workbench environment | |||
- A project set up for that researcher that can launch EC2 workspaces and Sagemaker workspaces | |||
- Within that project, a study where the researcher is admin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #, if available:
Description of changes: Added clarifying details to the end-to-end testing tutorial and the configuration of machine images for workspaces instructions.
Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.