Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove workspace test that polls workflow #631

Merged
merged 3 commits into from
Aug 5, 2021

Conversation

ray7yu
Copy link
Contributor

@ray7yu ray7yu commented Aug 4, 2021

Issue #, if available:
N/A

Description of changes:
Remove provision workspace test to unblock other devs

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you successfully tested with your changes locally?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ray7yu ray7yu requested a review from a team as a code owner August 4, 2021 19:09
@github-actions github-actions bot added the size/s label Aug 4, 2021
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #631 (bc50acc) into develop (f81a04f) will not change coverage.
The diff coverage is n/a.

❗ Current head bc50acc differs from pull request most recent head 9efc6dc. Consider uploading reports for the commit 9efc6dc to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #631   +/-   ##
========================================
  Coverage    49.21%   49.21%           
========================================
  Files          246      246           
  Lines        12658    12658           
  Branches      2022     2022           
========================================
  Hits          6230     6230           
  Misses        5625     5625           
  Partials       803      803           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f81a04f...9efc6dc. Read the comment docs.

Copy link
Contributor

@maghirardelli maghirardelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for unblocking again!

@ray7yu ray7yu merged commit f11272d into develop Aug 5, 2021
@ray7yu ray7yu deleted the remove-provision-workspace-test branch August 5, 2021 15:04
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
* fix: remove workspace test that polls workflow

* fix: comment out unused sleep function

Co-authored-by: Raymond Yu <raymyu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants